Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant code #10

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

chen4903
Copy link
Contributor

endpoint_with_bundle_signer() is the same as authenticated_endpoint(). And authenticated_endpoint() is not used. So remove the first one.

@leruaa
Copy link
Owner

leruaa commented Oct 28, 2024

Good catch, thanks!

CI is not passing because I use secrets for the RPC url used in tests and you don't have access to that in your fork. I'll fix that asap.

@leruaa leruaa merged commit 259fac2 into leruaa:main Oct 28, 2024
2 of 6 checks passed
@chen4903 chen4903 deleted the remove-redundant-code branch October 29, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants