-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make compilation against GSL 2.3 & 2.4 succeed #141
Conversation
GSL has not build deprecated functions by default since commit c2dcd9a5647208ba78ceff56bad6eabd7b7e1991 in 2006. As of 2.{3,4}, more functions have been deprecated, affecting more modules than BSpline.
* functions new to 2.3 and 2.4 have been added to ver2func * no new tests!
@djerius thanks for this! Have you tested compiling the code when older GSL versions are present, to make sure that still works? Looks like Travis CI is not happy: https://travis-ci.org/leto/math--gsl/builds/290065663 Looks like a great start, let me know how I can help you debug. I didn't even see these GSL releases come out 😸 |
I was hoping that travis would do that, but that leads to your next statement:
Travis isn't even getting to the module testing phase. There's something in the setup which is giving it conniptions. All of the tests fail with:
I'm not at all familiar with travis, so help would be appreciated. |
244eb2b
to
0252afe
Compare
…l-master exists but is empty
I've fixed the bug in the travis |
@djerius it does seem that your patch makes the latest version work, but all previous versions are failing. When I looked on Travis, I saw this as one of the first errors:
It may be that GSL upstream changed backward compatibility, I am not sure, things get really hairy if they did. |
I've undoubtedly broken things, but since fixing the Travis configuration so testing against older versions worked I've had no time to look at this. I'll find the time to split out the Travis fixes so that they can be applied to the master branch. |
This is superseded by PR #158 |
This patch includes the minimal changes to allow compilation under GSL 2.3 & GSL 2.4