Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compilation against GSL 2.3 & 2.4 succeed #141

Closed
wants to merge 4 commits into from

Conversation

djerius
Copy link
Contributor

@djerius djerius commented Oct 19, 2017

This patch includes the minimal changes to allow compilation under GSL 2.3 & GSL 2.4

GSL has not build deprecated functions by default since
commit c2dcd9a5647208ba78ceff56bad6eabd7b7e1991 in 2006.
As of 2.{3,4}, more functions have been deprecated, affecting
more modules than BSpline.
* functions new to 2.3 and 2.4 have been added to ver2func

* no new tests!
@leto
Copy link
Owner

leto commented Oct 19, 2017

@djerius thanks for this! Have you tested compiling the code when older GSL versions are present, to make sure that still works? Looks like Travis CI is not happy: https://travis-ci.org/leto/math--gsl/builds/290065663

Looks like a great start, let me know how I can help you debug. I didn't even see these GSL releases come out 😸

@djerius
Copy link
Contributor Author

djerius commented Oct 20, 2017

Have you tested compiling the code when older GSL versions are present, to make sure that still works?

I was hoping that travis would do that, but that leads to your next statement:

Looks like Travis CI is not happy: https://travis-ci.org/leto/math--gsl/builds/290065663

Travis isn't even getting to the module testing phase. There's something in the setup which is giving it conniptions. All of the tests fail with:

git rev-parse master

fatal: Not a git repository (or any of the parent directories): .git

The command "./_travis/before_install.sh" failed and exited with 128 during .

Your build has been stopped.

I'm not at all familiar with travis, so help would be appreciated.

@djerius
Copy link
Contributor Author

djerius commented Nov 3, 2017

I've fixed the bug in the travis before_install script (and made a few other changes), so builds are now running properly and I can get results against the other versions of GSL.

@anadon
Copy link

anadon commented Jan 23, 2018

I'm running into odd things with this as well (#146 #147 ). I think this does need some active attention and is related.

@leto
Copy link
Owner

leto commented Feb 22, 2018

@djerius it does seem that your patch makes the latest version work, but all previous versions are failing. When I looked on Travis, I saw this as one of the first errors:

xs/Integration_wrap.2.2.1.c:2045:5: error: ‘gsl_integration_fixed_legendre’ undeclared (first use in this function)
     gsl_integration_fixed_legendre = (gsl_integration_fixed_type *)(argp);
     ^

It may be that GSL upstream changed backward compatibility, I am not sure, things get really hairy if they did.

@djerius
Copy link
Contributor Author

djerius commented Feb 22, 2018

I've undoubtedly broken things, but since fixing the Travis configuration so testing against older versions worked I've had no time to look at this. I'll find the time to split out the Travis fixes so that they can be applied to the master branch.

@djerius
Copy link
Contributor Author

djerius commented Oct 28, 2018

This is superseded by PR #158

@djerius djerius closed this Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants