Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove config live reloader package #7112

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Remove config live reloader package #7112

merged 11 commits into from
Oct 26, 2023

Conversation

pgporada
Copy link
Member

@pgporada pgporada commented Oct 11, 2023 •
edited
Loading

The CA, RA, and tools importing the PA (policy authority) will no longer be able to live reload specific config files. Each location is now responsible for loading the config file.

  • Removed the reloader package
  • Removed unused ecdsa_allow_list_status metric from the CA
  • Removed mutex from all ratelimit limitsImpl methods

Fixes #7111

@pgporada pgporada marked this pull request as ready for review October 12, 2023 16:18
@pgporada pgporada requested a review from a team as a code owner October 12, 2023 16:18
beautifulentropy
beautifulentropy requested changes Oct 24, 2023
View reviewed changes
ratelimit/rate-limits.go Outdated Show resolved Hide resolved
policy/pa.go Outdated Show resolved Hide resolved
cmd/boulder-ca/main.go Outdated Show resolved Hide resolved
ca/ecdsa_allow_list.go Outdated Show resolved Hide resolved
ca/ecdsa_allow_list.go Outdated Show resolved Hide resolved
pgporada and others added 4 commits October 24, 2023 15:34
@pgporada @beautifulentropy
Update policy/pa.go
9b3f206 
Co-authored-by: Samantha <hello@entropy.cat>
@pgporada @beautifulentropy
Update cmd/boulder-ca/main.go
39e6356 
Co-authored-by: Samantha <hello@entropy.cat>
@pgporada @beautifulentropy
Update ratelimit/rate-limits.go
42243f3 
Co-authored-by: Samantha <hello@entropy.cat>
@pgporada
Remove length method
a3c6805
@pgporada pgporada requested review from a team and beautifulentropy October 24, 2023 19:46
@beautifulentropy beautifulentropy requested a review from a team October 24, 2023 20:26
aarongable
aarongable previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with three minor comments, all of which are wholly optional.

ca/ecdsa_allow_list.go Outdated Show resolved Hide resolved
policy/pa.go Outdated Show resolved Hide resolved
ra/ra.go Outdated Show resolved Hide resolved
@pgporada @aarongable
Update ca/ecdsa_allow_list.go
f5559db 
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
@pgporada pgporada dismissed stale reviews from aarongable and beautifulentropy via f5559db October 26, 2023 18:22
@pgporada pgporada merged commit 000cd05 into main Oct 26, 2023
20 checks passed
@pgporada pgporada deleted the deloader branch October 26, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beautifulentropy beautifulentropy beautifulentropy approved these changes

@aarongable aarongable aarongable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the reloader package
3 participants
@pgporada @aarongable @beautifulentropy