Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename protobuf duration fields to <fieldname>NS and populate new duration fields #7115

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Rename protobuf duration fields to <fieldname>NS and populate new duration fields #7115

merged 4 commits into from
Oct 26, 2023

Conversation

pgporada
Copy link
Member

  • Renames all of int64 as a time.Duration fields to <fieldname>NS to indicate they are Unix nanoseconds.
  • Adds new google.protobuf.Duration fields to each .proto file where we previously had been using an int64 field to populate a time.Duration.
  • Updates relevant gRPC messages.

Part 1 of 3 for #7097

@pgporada pgporada requested a review from a team as a code owner October 12, 2023 17:50
@pgporada pgporada requested a review from jsha October 12, 2023 17:50
jsha
jsha requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test-only tweak, otherwise looks good.

grpc/test_proto/interceptors_test.proto Outdated Show resolved Hide resolved
@pgporada pgporada requested review from jsha and a team October 24, 2023 20:22
@pgporada pgporada requested a review from a team October 25, 2023 18:06
@pgporada pgporada merged commit b8b1054 into main Oct 26, 2023
20 checks passed
@pgporada pgporada deleted the insert-clever-duration-based-pr-name-here branch October 26, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beautifulentropy beautifulentropy beautifulentropy approved these changes

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgporada @jsha @beautifulentropy