-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
va: Check for RIR and Perspective mismatches at runtime when they're provided #7841
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Looking at the "do not merge" instructions makes me think: is there a way we can land most of this code without waiting, to avoid complicated merge stacks?
For instance, the change from
Perspective string `validate:"omitempty"`
to
Perspective string `validate:"required"`
Could land right now, since we're not yet using the remoteva
in prod.
In general, I think all of this PR could land right now, with the small exception of va.go:243
. If we leave the va1.Perspective != ""
check in place, this all becomes mergeable right away. Effectively we're saying "if the primary VA has perspective and RIR configured, it will check them against the backend values, but if they're not configured, it won't." Then after the necessary deploys happen we could remove that check (and also set the relevant fields as validate:required
in the configs).
FWIW, I think |
This was actually correct in the original PR but it was reverted by a merge: 64a9a3a |
78aa24b
…spective/rir are specified
Late to the party, but this looks good to me! 🎉 |
Part of #7819