Deprecate DisableLegacyLimitWrites & UseKvLimitsForNewOrder flags; remove code using certificatesPerName & newOrdersRL tables

cmd/boulder-ra/main.go

@@ -34,7 +34,8 @@ type Config struct {
 		cmd.ServiceConfig
 		cmd.HostnamePolicyConfig
 
-		RateLimitPoliciesFilename string `validate:"required"`
+		// RateLimitPoliciesFilename is deprecated.
+		RateLimitPoliciesFilename string
 
 		MaxContactsPerRegistration int
 
@@ -297,8 +298,6 @@ func main() {
 	)
 	defer rai.Drain()
 
-	policyErr := rai.LoadRateLimitPoliciesFile(c.RA.RateLimitPoliciesFilename)
-	cmd.FailOnError(policyErr, "Couldn't load rate limit policies file")
 	rai.PA = pa
 
 	rai.VA = va.RemoteClients{

db/map_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/letsencrypt/borp"
 
 	"github.com/go-sql-driver/mysql"
+
 	"github.com/letsencrypt/boulder/core"
 	"github.com/letsencrypt/boulder/test"
 	"github.com/letsencrypt/boulder/test/vars"
@@ -185,10 +186,6 @@ func TestTableFromQuery(t *testing.T) {
 			query:         "insert into `certificates` (`registrationID`,`serial`,`digest`,`der`,`issued`,`expires`) values (?,?,?,?,?,?);",
 			expectedTable: "`certificates`",
 		},
-		{
-			query:         "INSERT INTO certificatesPerName (eTLDPlusOne, time, count) VALUES (?, ?, ?) ON DUPLICATE KEY UPDATE count=count+1;",
-			expectedTable: "certificatesPerName",
-		},
 		{
 			query:         "insert into `fqdnSets` (`ID`,`SetHash`,`Serial`,`Issued`,`Expires`) values (null,?,?,?,?);",
 			expectedTable: "`fqdnSets`",

features/features.go

@@ -16,7 +16,9 @@ import (
 // package's global Config.
 type Config struct {
 	// Deprecated flags.
-	IncrementRateLimits bool
+	IncrementRateLimits      bool
+	UseKvLimitsForNewOrder   bool
+	DisableLegacyLimitWrites bool
 
 	// ServeRenewalInfo exposes the renewalInfo endpoint in the directory and for
 	// GET requests. WARNING: This feature is a draft and highly unstable.
@@ -67,21 +69,6 @@ type Config struct {
 	// until the paused identifiers are unpaused and the order is resubmitted.
 	CheckIdentifiersPaused bool
 
-	// UseKvLimitsForNewOrder when enabled, causes the key-value rate limiter to
-	// be the authoritative source of rate limiting information for new-order
-	// callers and disables the legacy rate limiting checks.
-	//
-	// Note: this flag does not disable writes to the certificatesPerName or
-	// fqdnSets tables at Finalize time.
-	UseKvLimitsForNewOrder bool
-
-	// DisableLegacyLimitWrites when enabled, disables writes to:
-	//   - the newOrdersRL table at new-order time, and
-	//   - the certificatesPerName table at finalize time.
-	//
-	// This flag should only be used in conjunction with UseKvLimitsForNewOrder.
-	DisableLegacyLimitWrites bool
-
 	// PropagateCancels controls whether the WFE and ocsp-responder allows
 	// cancellation of an inbound request to cancel downstream gRPC and other
 	// queries. In practice, cancellation of an inbound request is achieved by

mocks/sa.go

@@ -311,16 +311,6 @@ func (sa *StorageAuthorityReadOnly) FQDNSetExists(_ context.Context, _ *sapb.FQD
 	return &sapb.Exists{Exists: false}, nil
 }
 
-// CountCertificatesByNames is a mock
-func (sa *StorageAuthorityReadOnly) CountCertificatesByNames(_ context.Context, _ *sapb.CountCertificatesByNamesRequest, _ ...grpc.CallOption) (*sapb.CountByNames, error) {
-	return &sapb.CountByNames{}, nil
-}
-
-// CountOrders is a mock
-func (sa *StorageAuthorityReadOnly) CountOrders(_ context.Context, _ *sapb.CountOrdersRequest, _ ...grpc.CallOption) (*sapb.Count, error) {
-	return &sapb.Count{}, nil
-}
-
 // DeactivateRegistration is a mock
 func (sa *StorageAuthority) DeactivateRegistration(_ context.Context, _ *sapb.RegistrationID, _ ...grpc.CallOption) (*emptypb.Empty, error) {
 	return &emptypb.Empty{}, nil