Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run most workflows on ubuntu-24.04 #7875

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Run most workflows on ubuntu-24.04 #7875

merged 4 commits into from
Dec 6, 2024

Conversation

mcpherrinm
Copy link
Contributor

@mcpherrinm mcpherrinm commented Dec 6, 2024

Github is currently rolling out ubuntu-latest as ubuntu-24.04. Manage that switch explicitly by running most jobs on 24.04

actions/runner-images#10636

This keeps the release on 20.04 to ensure released binaries can run on older operating systems (because of CGO/glibc versions)

@mcpherrinm mcpherrinm requested a review from a team as a code owner December 6, 2024 19:02
@mcpherrinm mcpherrinm requested a review from aarongable December 6, 2024 19:02
Github is currently rolling out ubuntu-latest as ubuntu-24.04

Manage that switch explicitly by running most jobs on 24.04

This keeps the release on 20.04 to ensure released binaries don't use a too-new
glibc for CGO.
jprenken
jprenken previously approved these changes Dec 6, 2024
jsha
jsha previously approved these changes Dec 6, 2024
aarongable
aarongable previously approved these changes Dec 6, 2024
Copy link
Contributor

@aarongable aarongable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd slightly prefer to keep codeql, cps-review, and issue-for-sre-handoff on ubuntu-latest, just so we don't have to go back to worrying about those versions again in the future.

@mcpherrinm mcpherrinm dismissed stale reviews from aarongable, jsha, and jprenken via c707eb8 December 6, 2024 20:42
@mcpherrinm
Copy link
Contributor Author

Sure, no problem leaving them on -latest.

We did observe that they pass on 24.04, which is the most important part for avoiding future unexpected breakage.

@aarongable aarongable merged commit 7e8b3fa into main Dec 6, 2024
12 checks passed
@aarongable aarongable deleted the mattm-ubuntu-latest branch December 6, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants