sa: remove CountFQDNSetTimestamps #7883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was superseded in #6220 by FQDNTimestampsForWindow and is no longer called.
aarongable
reviewed
Dec 12, 2024
|
@jsha you've still got some CI failures to resolve here. |
|
Huh, this is one I haven't seen before: |
|
Build fixed 🔨 |
aarongable
previously approved these changes
Dec 13, 2024
sa/proto/sa.proto
Outdated
| @@ -179,6 +177,7 @@ message CountFQDNSetsRequest { | |||
| reserved 1; // Previously windowNS | |||
| repeated string dnsNames = 2; | |||
| google.protobuf.Duration window = 3; | |||
| int64 limit = 4; | |||
There was a problem hiding this comment.
Do you want this to be here? I believe this is in service to your other PR, so maybe it makes sense to land it early for the sake of deployability, but want to double-check that its inclusion in this PR is purposeful.
There was a problem hiding this comment.
Nope, thanks for catching 🤦🏻
aarongable
approved these changes
Dec 13, 2024
aarongable
requested review from
a team and
jprenken
and removed request for
a team
jprenken
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was superseded in #6220 by FQDNTimestampsForWindow and is no longer called.