Revert "wfe: on rate limit error, serve 500 (#7796)" #7900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 242d746. We want to make this change, but it carries some risk that we'd prefer not to take over the holiday. We'd also like to keep `main` in a state where it would be reasonable to deploy (even if, in practice, any over-the-holiday deploy would be a hotfix, not a direct tag from `main`).
aarongable
previously approved these changes
Dec 18, 2024
aarongable
requested review from
a team and
beautifulentropy
and removed request for
a team
|
I think merging a revert on one review is acceptable, but I've requested review from the rest of dev anyway. |
beautifulentropy
previously approved these changes
Dec 18, 2024
jsha
dismissed stale reviews from beautifulentropy and aarongable
via
8a293fc
|
Pushed to fix merge conflicts. |
beautifulentropy
approved these changes
Dec 20, 2024
jprenken
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 242d746 (#7796)
We want to make this change, but it carries some risk that we'd prefer not to take over the holiday. We'd also like to keep
mainin a state where it would be reasonable to deploy (even if, in practice, any over-the-holiday deploy would be a hotfix, not a direct tag frommain).