ra: log User-Agent #7908
Open
ra: log User-Agent #7908
+117
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprenken
approved these changes
Dec 20, 2024
jprenken
requested review from
a team and
aarongable
and removed request for
a team
aarongable
approved these changes
Dec 20, 2024
| @@ -18,12 +18,14 @@ import ( | |||
|
|
|||
| "github.com/letsencrypt/boulder/cmd" | |||
| berrors "github.com/letsencrypt/boulder/errors" | |||
| "github.com/letsencrypt/boulder/web" | |||
There was a problem hiding this comment.
It feels a little odd to have a dependency going from grpc to web. I think it's probably the right thing to do, given the existence of //web/context.go, but it does make me think that file should maybe be moved to its own package someday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the WFE, store the User-Agent in a
context.Contextobject. In our gRPC interceptors, pass that field in a Metadata header, and re-add it toContexton the server side.Add a test in the gRPC interceptors that User-Agent is properly propagated.
Note: this adds a new
setup()function for the gRPC tests that is currently only used by the new test. I'll upload another PR shortly that expands the use of that function to more tests.Note: this change is based on #7888. DO NOT MERGE until that change merges.