Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various CI/linting updates #10

Merged
merged 4 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ on:

jobs:
test:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Go
uses: actions/setup-go@v2
uses: actions/setup-go@v5
with:
go-version: 1.18
go-version: 1.23

- name: Build
run: go build -v ./...
Expand All @@ -28,7 +28,6 @@ jobs:
run: go test -v ./...

- name: Lint
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v6
with:
version: v1.45.2
only-new-issues: true
version: v1.61
12 changes: 9 additions & 3 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,18 @@ linters:
- stylecheck
- gosec
- dupl
- maligned
- depguard
- lll
- prealloc
- scopelint
- gocritic
- gochecknoinits
- gochecknoglobals
- typecheck # Go 1.13 incompatible pending new golangci-lint binary release
- exhaustruct
- testpackage
- paralleltest
- nlreturn
- perfsprint
# These are deprecated
- execinquery
- exportloopref
- gomnd
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/letsencrypt/gorepotemplate

go 1.18
go 1.23
1 change: 1 addition & 0 deletions hello.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ func Hello(name string) string {
if name == "" {
return "Hello"
}

return fmt.Sprintf("Hello %s", strings.ToLower(name))
}
Loading