feat: separate Passages tables #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 12, 2024 12:06
* Cascading deletes for sources-passages * Fixed hard_delete bug in source_manager * New passage_manager functions and tests. Removed 'cursor' from list_passages
* modified passage tests * passage listing consists of union of agent and source passages
mlong93
changed the title
mattzh72
reviewed
Dec 13, 2024
* Added test for two agents attaching same source * agent_passages should be deleted when an agent is deleted * Fixed agent manager bug
mattzh72
reviewed
Dec 16, 2024
mattzh72
reviewed
Dec 16, 2024
mattzh72
reviewed
Dec 16, 2024
mattzh72
reviewed
Dec 16, 2024
mattzh72
approved these changes
Dec 16, 2024
|
TODO: unify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?
How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
Related issues or PRs
Please link any related GitHub issues or PRs.
Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.
Additional context
Add any other context or screenshots about the PR here.