Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding init tool rule for Anthropic endpoint #2262

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

mlong93
Copy link
Collaborator

@mlong93 mlong93 commented Dec 17, 2024

https://linear.app/letta/issue/LET-508/inittool-tool-rule

  • Fixed first message flag
  • Added support for Claude-3-sonnet configs
  • New test case for init tool rule

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

* Fixed first message flag
* Added support for Claude-3-sonnet configs
* New test case for init tool rule
letta/agent.py Outdated Show resolved Hide resolved
letta/constants.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a check in the agent creation/update that there is only 1 init tool rule unless the model is in STRUCTURED_OUTPUT_MODELS and throws an informative error (e.g. Only one instance of InitToolRule allowed .... ) otherwise?

Otherwise looks great!

@sarahwooders sarahwooders merged commit 1845651 into main Dec 17, 2024
38 of 40 checks passed
@mlong93 mlong93 deleted the mindy/LET508-init-tool-rule branch December 17, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants