fix: propagate error on tool failure #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carenthomas
temporarily deployed
to
Deployment
GitHub Actions
Inactive
carenthomas
force-pushed
the
caren/let-573-when-a-tool-fails-do-not-propogate-ok
branch
from
3527008 to
1e34c3a
Compare
carenthomas
temporarily deployed
to
Deployment
GitHub Actions
Inactive
carenthomas
force-pushed
the
caren/let-573-when-a-tool-fails-do-not-propogate-ok
branch
from
1e34c3a to
a595374
Compare
carenthomas
temporarily deployed
to
Deployment
GitHub Actions
Inactive
carenthomas
temporarily deployed
to
Deployment
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
reinstate prior functionality. following up with a more robust implementation that doesn't infer status based on the string (but this is fine for now since I am setting the string the same way at all callsites)
How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
poetry run pytest -s -vv tests/test_client.py::test_function_always_error
Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
Related issues or PRs
Please link any related GitHub issues or PRs.
Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.
Additional context
Add any other context or screenshots about the PR here.