Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add underlying error message for Retries Exhausted error #2308

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

carenthomas
Copy link
Collaborator

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

Additional context
Add any other context or screenshots about the PR here.

@carenthomas
Copy link
Collaborator Author

carenthomas commented Dec 22, 2024

Want to improve this error, as it currently hides info from the user. Adding the underlying error message, and based on what's happening we can create more granular exception types to handle each case rather than relying on generic ValueError/Exception

This shows as generic send message error in UI:

Screenshot 2024-12-22 at 11 01 00 AM

@carenthomas carenthomas changed the title fix: add underlying error message fix: add underlying error message for Retries Exhausted error Dec 22, 2024
@carenthomas carenthomas merged commit 3b94b45 into main Dec 22, 2024
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants