Pega tema do sistema do usuário, remove piscada quando tema escuro #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Araújo <george.gcac@gmail.com>
Signed-off-by: George Araújo <george.gcac@gmail.com>
✅ Deploy Preview for diciotech ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: George Araújo <george.gcac@gmail.com>
Signed-off-by: George Araújo <george.gcac@gmail.com>
|
@george-gca se tu conseguir dar um check nos conflitos 🫰🏻 |
|
Então, o #218 mudou os arquivos css, mas na verdade é pra gente mexer nos sass e regerar os css. Vou ver se consigo pegar a mudança dele e botar no sass. |
Signed-off-by: George Araújo <george.gcac@gmail.com>
|
@levxyca foi o/ |
|
@george-gca boaaaaaaaa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição de PR
Removi arquivos inutilizados, resolvi piscada quando o tema escuro é o que está selecionado (ao atualizar a página) e adicionei suporte a pegar tema do sistema.
Issue relacionado
Motivações
Já que eu estava com a mão na massa (implementando uma versão da tradução no #217), vi que ia ser tranquilo resolver a #173 e acabei junto resolvendo a outra.
Informações adicionais
Eu apaguei vários arquivos css, já que o sass compila tudo no style.css. Também criei um arquivo pro tema claro, pra ficar mais separado onde as cores dos temas são tratadas.