Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolvido bug ao ordenar arquivos com dados #263

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

george-gca
Copy link
Contributor

@george-gca george-gca commented Nov 2, 2024

Descrição de PR

Por algum motivo eu apaguei uma linha do workflow sem querer e só percebi quando o código subiu. Consertando agora. Aproveitei e consegui testar no meu branch mesmo e resolvi um bug que tinha, agora tá funcionando. Só dar uma olhada na PR de teste que eu fiz pro meu fork aqui george-gca#4.

Eu fiz 1 só commit (via interface web do GitHub), mas na PR aparecem 2

image

O commit que ordena os dados aparece assim

image

Pra comparação, o meu commit george-gca@92cb8bb e o commit que o workflow gerou ordenando os dados george-gca@eb1e766

Issue relacionado

Signed-off-by: George Araújo <george.gcac@gmail.com>
Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for diciotech ready!

Name Link
🔨 Latest commit daa8dde
🔍 Latest deploy log https://app.netlify.com/sites/diciotech/deploys/6733ad381b1c4900084efdd4
😎 Deploy Preview https://deploy-preview-263--diciotech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: George Araújo <george.gcac@gmail.com>
Signed-off-by: George Araújo <george.gcac@gmail.com>
@george-gca george-gca changed the title Fixed sort data files Resolvido bug ao ordenar arquivos com dados Nov 2, 2024
@levxyca levxyca self-requested a review November 12, 2024 19:31
@levxyca levxyca added the bug Something isn't working label Nov 12, 2024
@levxyca levxyca added this to the v2 milestone Nov 12, 2024
@levxyca levxyca linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link
Owner

@levxyca levxyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@levxyca levxyca merged commit 4c9e26d into levxyca:main Nov 12, 2024
4 of 5 checks passed
@george-gca george-gca deleted the fix_sort_data branch November 12, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ordenar dados ao submeter uma PR
2 participants