Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap configuration file as structure in class OpenEVEC #837

Closed
uncleDecart opened this issue Dec 19, 2022 · 0 comments · Fixed by #906
Closed

Wrap configuration file as structure in class OpenEVEC #837

uncleDecart opened this issue Dec 19, 2022 · 0 comments · Fixed by #906
Assignees
@giggsoff

Comments

@uncleDecart
Copy link
Collaborator

uncleDecart commented Dec 19, 2022 •
edited
Loading

What

Don't pass configuration every for a function call, make it something like this

func CreateOpenEVEC(cfg *EdenSetupArgs) *OpenEVEC
func (c *OpenEVEC) StartEve(vmName, tapInterface string) error

Related issues

Originally posted by @giggsoff in #835 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giggsoff giggsoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor openevec to base actions on top of type and fix multiple configs itmo-eve/eden
2 participants
@giggsoff @uncleDecart