Refactor openevec to base actions on top of type and fix multiple configs

[giggsoff]

To use the same semantic in openevec we should use the same base type.
Also we use novel changers to load config directly to be able to load config directly from openevec.

[uncleDecart]

@giggsoff I see from review that you are removing cfg from parameters and rely on reading config from file which creates unnecessary coupling. That brings back things that I tried to revert with my previous PRs: you don't have single configuration file object, you will have to use ./eden config add before using any eden command.

I believe that this is not a way to go because you cannot simply create golang structure and use it when calling any openEVEC functions and pass it (see here)

[giggsoff]

@giggsoff I see from review that you are removing cfg from parameters and rely on reading config from file which creates unnecessary coupling. That brings back things that I tried to revert with my previous PRs: you don't have single configuration file object, you will have to use ./eden config add before using any eden command.

I believe that this is not a way to go because you cannot simply create golang structure and use it when calling any openEVEC functions and pass it (see here)

Probably it is not so clear, but I try to do exactly what you mention. Instead of dirty magic inside of re-reading config from viper here I fixed and use InitVarsFromConfig which rely on config object you implemented before (EdenSetupArgs).
So, in you example, you will use something like:

cfg := ec.GetDefaultConfig(curPath)
openEVEC = openevec.CreateOpenEVEC(cfg)
...
openEVEC.PodDeploy(appLink, *pc)

[uncleDecart]

Seems like you don't need cfg in function anymore

[giggsoff]

Sorry, can you please elaborate, what exactly you want to see here?

[uncleDecart]

Unfortunately, I can't commit to your PR :D What I meant is yetus is complaining on unused variable, we can fix it by

diff --git a/cmd/edenPacket.go b/cmd/edenPacket.go
index 3f0e22e..82c60c1 100644
--- a/cmd/edenPacket.go
+++ b/cmd/edenPacket.go
@@ -16,7 +16,7 @@ func newPacketCmd(configName, verbosity *string) *cobra.Command {
                Short: `Manage VMs in Equinix Metal Platform`,
        }
 
-       packetCmd.AddCommand(newPacketVMCmd(cfg, &cfg.Packet.Key, &packetProjectName))
+       packetCmd.AddCommand(newPacketVMCmd(&cfg.Packet.Key, &packetProjectName))
 
        packetCmd.PersistentFlags().StringVarP(&cfg.Packet.Key, "key", "k", "", "packet key file")
        packetCmd.PersistentFlags().StringVarP(&packetProjectName, "project", "p", defaults.DefaultPacketProjectName, "project name on packet")
@@ -24,7 +24,7 @@ func newPacketCmd(configName, verbosity *string) *cobra.Command {
        return packetCmd
 }
 
-func newPacketVMCmd(cfg *openevec.EdenSetupArgs, packetKey, packetProjectName *string) *cobra.Command {
+func newPacketVMCmd(packetKey, packetProjectName *string) *cobra.Command {
        var packetVMCmd = &cobra.Command{
                Use:   "vm",
                Short: `Manage VMs in packet`,
@@ -34,7 +34,7 @@ func newPacketVMCmd(cfg *openevec.EdenSetupArgs, packetKey, packetProjectName *s
                {
                        Message: "Basic Commands",
                        Commands: []*cobra.Command{
-                               newPacketRunCmd(cfg, packetKey, packetProjectName),
+                               newPacketRunCmd(packetKey, packetProjectName),
                                newPacketDeleteCmd(packetKey, packetProjectName),
                                newPacketGetIPCmd(packetKey, packetProjectName),
                        },
@@ -46,7 +46,7 @@ func newPacketVMCmd(cfg *openevec.EdenSetupArgs, packetKey, packetProjectName *s
        return packetVMCmd
 }

[uncleDecart]

seems like no need for cfg in function as well

[uncleDecart]

@giggsoff I'll merge it and will follow up with PR to fix Yetus complains about unused variables

[uncleDecart]

follow-up PR #907