Add vcomlink test

[shjala]

This is a test for lf-edge/eve#4142, but I don't know which one should go first ?!

• Wait for next release with Qemu : add patch to fix bios linker loader assert eve#4204
• Open a PR to set eve tag to the latest
• Rebase against latest master
• Reduce the test verbosity before merging

[milan-zededa]

This is a test for lf-edge/eve#4142, but I don't know which one should go first ?!

If this test depends on the EVE PR and would fail until it is merged and released, then this PR should wait.
I typically mark such eden PR as draft until there is EVE version with the tested functionality available. Then I update DefaultEVETag in pkg/defaults as part of the PR and mark it as ready for review.

[shjala]

If this test depends on the EVE PR and would fail until it is merged and released, then this PR should wait.

Yeah, I get it. But it is a conundrum, how I can show that my PR in eve works fine without merging this test, and on the other hand merging this breaks the eden tests.

[shjala]

This is ready to be merge as soon as we get the new eve release.

[uncleDecart]

@shjala so EVE 13.3.0 supports the test?

[shjala]

@shjala so EVE 13.3.0 supports the test?

yes, it runs green locally, lets see what happens here.

[shjala]

This is really frustrating, it runs fine locally (running smoke test) but here fails to wait for the app to be ready, I increased the timer to 30m but still...

[uncleDecart]

We need to think if there's something in Eden or problem in runners...

[giggsoff]

This is really frustrating, it runs fine locally (running smoke test) but here fails to wait for the app to be ready, I increased the timer to 30m but still...

Inside attached artifacts (in console logs) I can see ERROR: App vcomlink-sleepy_leakey uuid 53ff1865-61bf-43dd-bab4-ab7c1ffe2fb6 state INSTALLED error: failed to run domain 53ff1865-61bf-43dd-bab4-ab7c1ffe2fb6.1.1: not based on an OCI image. AFAIK it indicates that you try to run VM (based on qcow2 image) on host without hardware assistance acceleration (or with app in no-hyper mode in config).

BTW it would be nice to show timestanps and errors if any in state transition in test logs (from AppWaitForRunningState function). It will helps to detect such problems quickly without diving into artifacts.

[shjala]

Inside attached artifacts (in console logs) I can see ERROR: App vcomlink-sleepy_leakey uuid 53ff1865-61bf-43dd-bab4-ab7c1ffe2fb6 state INSTALLED error: failed to run domain 53ff1865-61bf-43dd-bab4-ab7c1ffe2fb6.1.1: not based on an OCI image. AFAIK it indicates that you try to run VM (based on qcow2 image) on host without hardware assistance acceleration (or with app in no-hyper mode in config).

I see the eden default DefaultEVEH is KVM and in the app config NoHyper is set to false, and expectation.virtualizationMode = config.VmMode_HVM for amd64, are you suggesting I should move this to virtualization test suite?

BTW it would be nice to show timestanps and errors if any in state transition in test logs (from AppWaitForRunningState function). It will helps to detect such problems quickly without diving into artifacts.

Good point, I will add it.

[shjala]

I see require_virtualization: true only for virtualization test in github actions, I move this test to virt.

[shjala]

@giggsoff Thanks for your help. It is now passing as part of virtualization tests:

--- PASS: TestEdenScripts (0.00s)
    --- PASS: TestEdenScripts/eden_vcom (119.12s)

@milan-zededa @uncleDecart some other tests are failing but I'm not touching any part relevant to those, general flakiness? anyways this PR is ready.

[milan-zededa]

@giggsoff Thanks for your help. It is now passing as part of virtualization tests:

--- PASS: TestEdenScripts (0.00s)
    --- PASS: TestEdenScripts/eden_vcom (119.12s)

@milan-zededa @uncleDecart some other tests are failing but I'm not touching any part relevant to those, general flakiness? anyways this PR is ready.

We will retry them just in case. At least one of them is a known failure.

[shjala]

@milan-zededa @uncleDecart should we merge this?

[uncleDecart]

LGTM from my side, if @milan-zededa is okay with patch I'd merge it