GitHub Actions: switch to running Eden on GitHub runners #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently GitHub bumped the runners to be as powerful as BuildJet ones, and they're all free. So let's try them out Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
|
Huh, takes 1hr to finish smoke tests, maybe we need to enable those large runners, will check it out |
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart
force-pushed
the
switch-to-gh-runners
branch
from
c0430f6
to
0c13836
Compare
|
GitHub runners don't have HW support for Virtualization. That will slow down the whole thing... Not sure if switching makes sense now |
Without virtualization support I do not think that the switch makes sense - it will take longer, we will get more random failures and Virtualization test suite will always fails. |
|
Closing PR, since there's no reason to switch to GitHub Runners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently GitHub bumped the runners to be as powerful as BuildJet ones, and they're all free. So let's try them out