Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable workflows for eden tests #876

Closed
wants to merge 0 commits into from
Closed

Reusable workflows for eden tests #876

wants to merge 0 commits into from

Conversation

yash-zededa
Copy link
Contributor

@yash-zededa yash-zededa commented Jul 18, 2023

This PR will allow the lf-edge/eve to call the workflow from eden repo i.e re-usable workflow.

The configurations would be DRY and all the changes in eden can then be managed without having to copy them over to the eve.

@yash-zededa yash-zededa changed the title Reusable workflows for eden tests Draft: Reusable workflows for eden tests Jul 18, 2023
@yash-zededa yash-zededa changed the title Draft: Reusable workflows for eden tests Reusable workflows for eden tests Jul 19, 2023
@uncleDecart
Copy link
Collaborator

LGTM, some minor comments with your fork usage and path input variable

@milan-zededa
Copy link
Contributor

Do I get it right that this will allow us to get rid of the eden copy in the eve repo, i.e this directory?

@yash-zededa
Copy link
Contributor Author

@milan-zededa Yes, this PR would call the eden workflow from eve. The test workflow can be triggered in eden and eve both.

@uncleDecart
Copy link
Collaborator

Do I get it right that this will allow us to get rid of the eden copy in the eve repo, i.e this directory?

@milan-zededa Yes, this PR would call the eden workflow from eve. The test workflow can be triggered in eden and eve both.

And if you want to change version, you simply do so in new fancy GitHub action of ours :)

Copy link
Collaborator

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small comment about working-directory

@uncleDecart
Copy link
Collaborator

Hey @yash-zededa, could you rebase to master, looks like there're some small merge conflict.

@yash-zededa
Copy link
Contributor Author

Hey @yash-zededa, could you rebase to master, looks like there're some small merge conflict.

Sure,I will rebase it, I am testing the working-directory changed with the test.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants