-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reusable workflows for eden tests #876
Conversation
LGTM, some minor comments with your fork usage and path input variable |
Do I get it right that this will allow us to get rid of the eden copy in the eve repo, i.e this directory? |
@milan-zededa Yes, this PR would call the eden workflow from eve. The test workflow can be triggered in eden and eve both. |
And if you want to change version, you simply do so in new fancy GitHub action of ours :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small comment about working-directory
Hey @yash-zededa, could you rebase to master, looks like there're some small merge conflict. |
Sure,I will rebase it, I am testing the |
This PR will allow the lf-edge/eve to call the workflow from eden repo i.e re-usable workflow.
The configurations would be DRY and all the changes in eden can then be managed without having to copy them over to the eve.