Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting eve.tag and eve.registry for eden tests for PR's build #881

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

yash-zededa
Copy link
Contributor

A different repository is used for the eve PRs after they have been built. Although this value is present in the tag that Eve passes, we still need to extract the necessary data. Using the fundamental shell commands, this PR will retrieve the necessary data.

@uncleDecart uncleDecart self-requested a review July 27, 2023 13:33
Copy link
Collaborator

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except confusion with eve_tag forcing to have :

.github/actions/setup-environment/action.yml Outdated Show resolved Hide resolved
@eriknordmark
Copy link
Contributor

I see a no space left on device in the failure

@uncleDecart
Copy link
Collaborator

uncleDecart commented Jul 27, 2023

That's interesting @eriknordmark , because we are still not using this workflows, we run them manually till they are successful (and only then we want to use them in PRs). So this patch does not affect other workflows running (including eden_setup)

@eriknordmark
Copy link
Contributor

That's interesting @eriknordmark , because we are still not using this workflows, we run them manually till they are successful (and only then we want to use them in PRs). So this patch does not affect other workflows running (including eden_setup)

I was referring to the error for this PR in https://github.com/lf-edge/eden/actions/runs/5681201583/job/15396839195?pr=881

And they are being used in EVE (and all failing). See https://github.com/lf-edge/eve/actions/workflows/eden_test.yml
I assumed that was known

@yash-zededa
Copy link
Contributor Author

Reference

Yes, the Test from lf-edge/eden WF is being used by eve to test the reusable workflow functionality. Once this PR is merged. I will raise a PR that will fix eve.

Signed-off-by: yash-zededa <yash@zededa.com>
Copy link
Collaborator

@uncleDecart uncleDecart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uncleDecart uncleDecart merged commit dee1c36 into lf-edge:master Jul 28, 2023
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants