-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting eve.tag and eve.registry for eden tests for PR's build #881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except confusion with eve_tag
forcing to have :
I see a no space left on device in the failure |
That's interesting @eriknordmark , because we are still not using this workflows, we run them manually till they are successful (and only then we want to use them in PRs). So this patch does not affect other workflows running (including eden_setup) |
I was referring to the error for this PR in https://github.com/lf-edge/eden/actions/runs/5681201583/job/15396839195?pr=881 And they are being used in EVE (and all failing). See https://github.com/lf-edge/eve/actions/workflows/eden_test.yml |
Yes, the |
Signed-off-by: yash-zededa <yash@zededa.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A different repository is used for the eve PRs after they have been built. Although this value is present in the tag that Eve passes, we still need to extract the necessary data. Using the fundamental shell commands, this PR will retrieve the necessary data.