gic max version to boot on newer arm64 hosts #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can see problems while running on arm64 hosts with acceleration. Seems we should align gic version with the host one. According to docs (https://www.qemu.org/docs/master/system/arm/virt .html?highlight=gic%20version), max is the best option here. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
uncleDecart
approved these changes
Aug 18, 2023
eriknordmark
approved these changes
Sep 28, 2023
As I understand, we want to check arm buildjet runners and potentially stabilise other issues as well. |
|
Exactly @giggsoff , right now we are running manually buildjet workflow ot see if there any problems If not, we should explore buildjet arm runners (since they provide them) and if there is no problem with that, we can run this PR on buildjet arm runner and if it's successful, we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see problems while running on arm64 hosts with acceleration. Seems we should align gic version with the host one. According to docs,
maxis the best option here.