Remove deprecated packages

[ghost]

The following packages/functions were deprecated in the repo and has been addressed:

• io/ioutil
• strings.Title
• rand.Seed
• github.com/golang/protobuf/proto

[deitch]

That is a lot of cleanup and modernization.

[giggsoff]

It seems we should update base image we use to build go code after moving to new go version (for example I can see potential problem here https://github.com/lf-edge/eden/blob/master/Dockerfile, probably we can find other places with the same problem), can you please check?

[ghost]

It seems we should update base image we use to build go code after moving to new go version (for example I can see potential problem here https://github.com/lf-edge/eden/blob/master/Dockerfile, probably we can find other places with the same problem), can you please check?

I ran make build-docker , make build and make install all ran successfully. Is there any other way to verify this issue ?

[giggsoff]

It seems we should update base image we use to build go code after moving to new go version (for example I can see potential problem here https://github.com/lf-edge/eden/blob/master/Dockerfile, probably we can find other places with the same problem), can you please check?

I ran make build-docker , make build and make install all ran successfully. Is there any other way to verify this issue ?

It is make build-docker, sorry, it is not so obvious.

[ghost]

It seems we should update base image we use to build go code after moving to new go version (for example I can see potential problem here https://github.com/lf-edge/eden/blob/master/Dockerfile, probably we can find other places with the same problem), can you please check?

I ran make build-docker , make build and make install all ran successfully. Is there any other way to verify this issue ?

It is make build-docker, sorry, it is not so obvious.

Thanks @giggsoff .

Yes, make build-docker was successful:
https://ctxt.io/2/AABQOoQeEA

[giggsoff]

It seems we should update base image we use to build go code after moving to new go version (for example I can see potential problem here https://github.com/lf-edge/eden/blob/master/Dockerfile, probably we can find other places with the same problem), can you please check?

I ran make build-docker , make build and make install all ran successfully. Is there any other way to verify this issue ?

It is make build-docker, sorry, it is not so obvious.

Thanks @giggsoff .

Yes, make build-docker was successful: https://ctxt.io/2/AABQOoQeEA

Good to know, thank you!

One question so far: I still can see github.com/golang/protobuf v1.5.2 in go.mod, can we avoid usage of the deprecated package? If it is not so easy, please do go mod tidy to indicate that we use the package indirectly.

[ghost]

mod

You are right. Thanks, I addressed it.

[giggsoff]

It looks quite strange that all tests failed so early in the same place, will check a bit later

[giggsoff]

Well, seems I found the problem @prnvkv-zededa. Please use cases.NoLower option in all your cases.Title calls to work the same way as old strings.Title one.

[ghost]

Well, seems I found the problem @prnvkv-zededa. Please use cases.NoLower option in all your cases.Title calls to work the same way as old strings.Title one.

Thanks @giggsoff !
Added the cases.Nolower option.

[giggsoff]

Can you please sign off your commits? I can see that DCO check failed.