Test replacement of one application with another #891
Conversation
milan-zededa
force-pushed
the
app-replace-test
branch
from
1958481
to
823f86c
Compare
milan-zededa
force-pushed
the
app-replace-test
branch
2 times, most recently
from
d4f598f
to
a67030d
Compare
milan-zededa
force-pushed
the
app-replace-test
branch
from
a67030d
to
1044e40
Compare
|
@uncleDecart @giggsoff This new test is now ready for review and it is expected to pass with EVE >10.10. |
|
@uncleDecart @giggsoff Please review :) |
|
|
||
| # Change the second app UUID which is effectively the same as replacing | ||
| # one application with another in one config iteration. | ||
| exec -t 1m bash change-app-uuid.sh app2 |
There was a problem hiding this comment.
Please increase the time up to e.g. 5m. In my experiments with xen, 1m is not enough (I can see 130 seconds on my PC).
| eden.escript.test -testdata ../app/testdata/ -test.run TestEdenScripts/2dockers_test | ||
| /bin/echo Testing replacement of one application with another (27.2/{{$tests}}) | ||
| eden.escript.test -testdata ../app/testdata/ -test.run TestEdenScripts/app_replace_test |
There was a problem hiding this comment.
Not a blocker, but just to mention: test located here will run only on EdenGCP workflow for now, as we have {{ if or (eq $workflow "large") (eq $workflow "gcp") }} above.
There was a problem hiding this comment.
and we need to add this tests to new workflows, because EVE is using them. I suggest to put this in user app
There was a problem hiding this comment.
I already put this to user-apps.tests.txt
There was a problem hiding this comment.
My bad, didn't see it :D
There was a problem hiding this comment.
@giggsoff I didn't realize that the test would be skipped in the old workflow, but since we are going to move to the new workflow soon, I'm going to keep it as it is.
When device configuration is updated using tools like Terraform, it is possible that in one configuration iteration a user application is removed and immediately replaced with another. Because the previous and the new applications could have conflicting configurations, it is important for EVE to execute operations of replacement carefully and in the right order. And in case EVE fails to create the new app because the obsolete one still holds some resources (e.g. allocated IP address), it should make a retry attempt after the obsolete app is fully removed. Note that these scenarious were not working in EVE properly until the version 10.10, when a patch was submitted, meaning that this is the minimal version for this test to pass. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
app-replace-test
branch
from
1044e40
to
1d91b27
Compare
When device configuration is updated using tools like Terraform, it is possible that in one configuration iteration a user application is removed and immediately replaced with another. Because the previous and the new applications could have conflicting configurations, it is important for EVE to execute operations of replacement carefully and in the right order. And in case EVE fails to create the new app because the obsolete one still holds some resources (e.g. allocated IP address), it should make a retry attempt after the obsolete app is fully removed.
Note that these scenarios were not working in EVE properly until the version 10.10, when a patch was submitted, meaning that this is the minimal version for this test to pass.