Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file` #892

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

uncleDecart
Copy link
Collaborator

I sometimes miss PRs for eden, so I'm adding myself as code owner, so that I'll get notifications when somebody opens PR

cc: @eriknordmark

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@milan-zededa
Copy link
Contributor

Github allows to subscribe for all activity on the repository ;)

@uncleDecart
Copy link
Collaborator Author

That was lightning fast :D But that won't add me as reviewer on PR, would it?

@milan-zededa
Copy link
Contributor

That was lightning fast :D But that won't add me as reviewer on PR, would it?

No, but you will not miss anything.

@uncleDecart
Copy link
Collaborator Author

Fair @milan-zededa , but I think adding CODEOWNERS make sense to automatically assign PR on eden, right now it could be simple * pattern for now, but it's better to start early, than late. It is easier to add small things, than to try to fix big one

For instance, we can assign sdn on you, since you're the author :D And I can also add you under * pattern

@milan-zededa
Copy link
Contributor

Fair @milan-zededa , but I think adding CODEOWNERS make sense to automatically assign PR on eden, right now it could be simple * pattern for now, but it's better to start early, than late. It is easier to add small things, than to try to fix big one

For instance, we can assign sdn on you, since you're the author :D And I can also add you under * pattern

I'm OK with it, but unless I get write access from @eriknordmark, it will not work for my account (see lf-edge/eve#3471).

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 0305545 into lf-edge:master Sep 28, 2023
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants