Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: converter lose precision #3445

Merged
merged 6 commits into from
Dec 19, 2024
Merged

fix: converter lose precision #3445

merged 6 commits into from
Dec 19, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Dec 16, 2024

goos: darwin
goarch: amd64
pkg: github.com/lf-edge/ekuiper/v2/internal/converter/json
cpu: Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
BenchmarkFloatParse
BenchmarkFloatParse-4 1000000 1044 ns/op
PASS

goos: darwin
goarch: amd64
pkg: github.com/lf-edge/ekuiper/v2/internal/converter/json
cpu: Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz
BenchmarkIntParse
BenchmarkIntParse-4 1763830 661.6 ns/op
PASS

Signed-off-by: Song Gao <disxiaofei@163.com>
@Yisaer Yisaer requested a review from ngjaying December 16, 2024 03:07
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.36%. Comparing base (1ebc3ae) to head (f31e9ec).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/converter/json/converter.go 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3445      +/-   ##
==========================================
+ Coverage   71.34%   71.36%   +0.02%     
==========================================
  Files         412      412              
  Lines       47154    47292     +138     
==========================================
+ Hits        33640    33748     +108     
- Misses      10886    10910      +24     
- Partials     2628     2634       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yisaer Yisaer requested a review from ngjaying December 17, 2024 03:18
Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just

internal/xsql/parser.go Outdated Show resolved Hide resolved
internal/xsql/parser.go Outdated Show resolved Hide resolved
Signed-off-by: Song Gao <disxiaofei@163.com>

fix

Signed-off-by: Song Gao <disxiaofei@163.com>

fix

Signed-off-by: Song Gao <disxiaofei@163.com>
@ngjaying ngjaying merged commit e952b40 into lf-edge:master Dec 19, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants