Skip to content

Commit

Permalink
PatchEnvelopes: Flatten ZInfoPatchEnvelopeUsage and remove Opaque S…
Browse files Browse the repository at this point in the history
…tatus

There is no need for additional structure since there is
1 to 1 releation. This commit also removes opaque status since it is
duplication of AppInstMetaData

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
  • Loading branch information
uncleDecart committed Oct 30, 2023
1 parent 960ae9e commit d545b7f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 30 deletions.
2 changes: 0 additions & 2 deletions proto/info/info.proto
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ enum ZInfoTypes {
ZiEdgeview = 12;
ZiLocation = 13;
ZiPatchEnvelope = 14;
ZiOpaqueAppInstanceStatus = 15;
}

// Information about assignable I/O adapter bundles
Expand Down Expand Up @@ -1135,7 +1134,6 @@ message ZInfoMsg {
ZInfoHardware hwinfo = 18;
ZInfoLocation locinfo = 19;
ZInfoPatchEnvelope patchInfo = 20;
ZInfoOpaqueAppInstanceStatus opaqueAppInstStatus = 21;
}
google.protobuf.Timestamp atTimeStamp = 6;
}
Expand Down
33 changes: 5 additions & 28 deletions proto/info/patch_envelope.proto
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ enum EVE_PATCH_ENVELOPE_STATE {
PATCH_ACTIVE = 6;
}

enum EVE_OPAQUE_STATUS_ACTION {
// Controller ignores the opaque status field
IGNORE = 0;

// Controller overwrites any existing opaque
// status with the content of opaque status sent
// in info message
OVERWRITE = 1;
}

message ZInfoPatchEnvelope {
string name = 1;
string id = 2;
Expand All @@ -55,28 +45,15 @@ message ZInfoPatchEnvelope {
repeated string errors = 6;
}

message ZInfoOpaqueAppInstanceStatus {
string appId = 1;
string appName = 2;
EVE_OPAQUE_STATUS_ACTION opaqueStatusAction = 3;
bytes opaqueStatus = 4;
}

// Provide information on PatchEnvelope usage per app
message ZInfoPatchEnvelopeUsage {
// count the number of times app instance called patch APIs
uint64 patchApiCallCount = 1;
// information about patchEnvelope referred to this app
ZInfoPatchEnvelopeApp patchStatus = 2;
}

// Statistics on usage of specific patchEnvelope for specific app
message ZInfoPatchEnvelopeApp {
// UUID of PatchEnvelope
string uuid = 1;
// Version of PatchEnvelope
string version = 2;
// Number of times this PatchEnvelope
// was sucessfully downloaded
uint64 timesDownloaded = 3;
// count the number of times app instance called patch APIs
uint64 patchApiCallCount = 3;
// count the number of times app instance actually downloaded
// whole patch envelope or part of it
uint64 timesDownload = 4;
}

0 comments on commit d545b7f

Please sign in to comment.