Fix Patch Envelope status spelling error and add ZiOpaqueAppInstanceStatus #29
Conversation
…tatus We need ZiOpaqueAppInstanceStatus in order to distinguish between status send by app and information about patch envelope assigned to app instance Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
|
@eriknordmark can you please check?Renaming is a breaking change, but status handling has not yet been merged to eve, so it does not affect it. |
There was a problem hiding this comment.
Since this is not used by any code we know of in EVE or controllers, fixing the typo in PATCH_RECIEVED is not an issue even at recompile of that software.
And since we are not changing the value it would never be an issue in the protobuf wire encoding compatibility.
Ignoring the yetus complaints about the prefixes since we follow the patten for the existing enum values.
|
Looking at the build and test failure, the diffs are additional empty lines in the output from protoc. Are you building this using the build container (which runs a well-know version of protoc)? |
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
uncleDecart
force-pushed
the
fix-patch-env-typo
branch
from
907a594 to
ba21021
Compare
|
@eriknordmark I rebuild it using devcontainer, works like charm :) |
We need ZiOpaqueAppInstanceStatus in order to distinguish between status send by app and information about patch envelope assigned to app instance