Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patch envelope status #32

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

uncleDecart
Copy link
Member

Since ZInfoPatchEnvelopeUsage itself is repeated repeating ZInfoPatchEnvelopeApp
is redundant

Status handling is not merged in EVE so it doesn't break anything in EVE code

Since ZInfoPatchEnvelopeUsage itself is repeated repeating ZInfoPatchEnvelopeApp
is redundant

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we do not yet have any user feedback on the PE usability at scale I'm far from certain that a single PE per app instance will be sufficient. Thus it sounds a bit counter-productive to change it from repeated to a single item. If it turns out that we only need one the API with repeated still works.

Should we chat about this with @gkodali-zededa ?

@uncleDecart
Copy link
Member Author

Sure @eriknordmark I think it makes sense

@gkodali-zededa
Copy link
Contributor

Given that we do not yet have any user feedback on the PE usability at scale I'm far from certain that a single PE per app instance will be sufficient. Thus it sounds a bit counter-productive to change it from repeated to a single item. If it turns out that we only need one the API with repeated still works.

Should we chat about this with @gkodali-zededa ?

@eriknordmark I think the question from Udit that lead to this PR is as follows
We already have a repeated ZInfoPatchEnvelopeUsage inside ZInfoApp. Why do we need another repeated ZInfoPatchEnvelopeApp inside ZInfoPatchEnvelopeUsage. We can leave the repeated ZInfoPatchEnvelopeUsage inside ZInfoApp for the case when we have multiple PEs attached. Will we also need the repeated ZInfoPatchEnvelopeApp?

@eriknordmark
Copy link
Contributor

Given that we do not yet have any user feedback on the PE usability at scale I'm far from certain that a single PE per app instance will be sufficient. Thus it sounds a bit counter-productive to change it from repeated to a single item. If it turns out that we only need one the API with repeated still works.
Should we chat about this with @gkodali-zededa ?

@eriknordmark I think the question from Udit that lead to this PR is as follows We already have a repeated ZInfoPatchEnvelopeUsage inside ZInfoApp. Why do we need another repeated ZInfoPatchEnvelopeApp inside ZInfoPatchEnvelopeUsage. We can leave the repeated ZInfoPatchEnvelopeUsage inside ZInfoApp for the case when we have multiple PEs attached. Will we also need the repeated ZInfoPatchEnvelopeApp?

Ah - in that case this change makes sense.

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yetus correctly flags this as an incompatible change so we can only do this because we know that none of the controllers have yet implemented the patch envelop part of the API.

@eriknordmark eriknordmark merged commit 960ae9e into lf-edge:main Oct 16, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants