Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on the default route propagation #40

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Clarification on the default route propagation #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f7e85
Clarification on default route propagation
milan-zededa Dec 14, 2023
2fbc357
Generate proto files
milan-zededa Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions go/config/netinst.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 14 additions & 5 deletions proto/config/netinst.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,12 @@ message NetworkInstanceConfig {
AddressType ipType = 39;

// network ip specification
// If ip.gateway is set to all-zeroes IP, default route will not be propagated
// to applications for interfaces connected to this network instance.
// Default route propagation is also automatically suppressed when the network
// instance is air-gapped or when the uplink is app-shared without default route
// configured. This behaviour can be further customized using static_routes
// (see below).
ipspec ip = 40;

// static DNS entry, if we are running DNS/DHCP service
Expand All @@ -137,11 +143,14 @@ message NetworkInstanceConfig {
// routes can be propagated at the same time, there are no restrictions for using both.
//
// Note that the default route (with the bridge IP as the gateway) is automatically
// propagated to connected applications unless explicitly disabled by setting
// NetworkInstanceConfig.ip.gateway to an all-zeroes IP or when the uplink is app-shared
// (not management) and does not have a default route of its own. In the latter case,
// it is possible to enforce default route propagation by configuring a static default
// route for the network instance.
// propagated to connected applications with these exceptions:
// a) default route propagation is explicitly disabled by setting
// NetworkInstanceConfig.ip.gateway to an all-zeroes IP
// b) network instance is air-gapped (without uplink)
// c) the uplink is app-shared (not management) and does not have a default route
// of its own
// In the b) and c) cases, it is possible to enforce default route propagation
eriknordmark marked this conversation as resolved.
Show resolved Hide resolved
// by configuring a static default route for the network instance.
//
// This option is only valid for local network instances. For other types
// of network instances, it will be ignored.
Expand Down
Loading