Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootloader mode capabilities #49

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

rene
Copy link
Contributor

@rene rene commented Mar 15, 2024

Add a new field to VmConfig representing the boot mechanism to be used to boot the VM. Three boot modes are added:

  • VM_BOOT_MODE_UNSPECIFIED: Boot mode not specified, use default
  • VM_BOOT_MODE_LEGACY: Legacy BIOS, when only MBR is supported
  • VM_BOOT_MODE_UEFI: UEFI capable BIOS

The optional capability boot_mode is also added in order to allow the device publish to the controller whether it supports different boot modes or not.

@rene rene requested a review from eriknordmark as a code owner March 15, 2024 10:26
proto/config/vm.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - stuck comment for two days

proto/info/info.proto Outdated Show resolved Hide resolved
rene added 2 commits April 12, 2024 14:54
Add a new field to VmConfig representing the boot mechanism to be used
to boot the VM. Three boot modes are added:

- VM_BOOT_MODE_UNSPECIFIED: Boot mode not specified, use default
- VM_BOOT_MODE_LEGACY: Legacy BIOS, when only MBR is supported
- VM_BOOT_MODE_UEFI: UEFI capable BIOS

Additionally, add API_CAPABILITY_BOOT_MODE to enum APICapability, clean up
deprecated comment and comment out API_CAPABILITY_EDGEVIEW.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
All changes after the 'make'.

Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 6fe2bd3 into lf-edge:main Apr 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants