Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to enable VNC for shim VM #50

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add flag to enable VNC for shim VM #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6445f10
Add .cache/ to .gitignore file
europaul Mar 20, 2024
5ed0a3f
devmodelcommon: mark field 8 as reserved
europaul Mar 20, 2024
2478983
proto: autogenerated protocol files
europaul Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.cache/
63 changes: 38 additions & 25 deletions go/config/vm.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 27 additions & 27 deletions go/evecommon/devmodelcommon.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion proto/config/vm.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
repeated uint32 irqs = 13;
repeated string iomem = 14;
VmMode virtualizationMode = 15;
bool enableVnc = 16;
// Enable VNC access to the edge application
bool enable_vnc = 16;

Check failure on line 53 in proto/config/vm.proto

View workflow job for this annotation

GitHub Actions / yetus 

bufcompat:Field "16" on message "VmConfig" changed name from "enableVnc" to "enable_vnc".
uint32 vncDisplay = 17;
string vncPasswd = 18;
// Change of the 'disable logs' field can be handled without VM reboot
Expand All @@ -68,4 +69,6 @@
// for one VM instance (guest RAM + VM monitor) is set according to the
// following equation: `memory` + `vmm_maxmem`
uint32 vmm_maxmem = 21;
// Enable VNC access to the shim VM harboring the edge application (for containers only)
bool enable_vnc_shim_vm = 22;
}
2 changes: 1 addition & 1 deletion proto/evecommon/devmodelcommon.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ enum PhyIoType {
PhyIoNetWLAN = 5;
PhyIoNetWWAN = 6;
PhyIoHDMI = 7;
// enum 8 is reserved for backward compatibility with controller API
reserved 8; // for backward compatibility with controller API
PhyIoNVMEStorage = 9;
PhyIoSATAStorage = 10;
PhyIoNetEthPF = 11;
Expand Down
8 changes: 4 additions & 4 deletions python/config/vm_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions python/evecommon/devmodelcommon_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading