Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on the MTU propagation from host to guest #58

Merged
merged 2 commits into from
May 24, 2024

Conversation

milan-zededa
Copy link
Contributor

Virtio interfaces do actually allow to propagate MTU value from the host to the guest.

Virtio interfaces allow to propagate MTU value from the host to the
guest.

Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Is there some place where folks can determine whether VIRTIO_ NET_F_MTU is supported? ethtool? Something else?

@milan-zededa
Copy link
Contributor Author

milan-zededa commented May 24, 2024

LGTM. Is there some place where folks can determine whether VIRTIO_ NET_F_MTU is supported? ethtool? Something else?

http://blog.vmsplice.net/2020/05/how-to-check-virtio-feature-bits-inside.html

Given that

#define VIRTIO_NET_F_MTU 3

We can check with:

# the position argument of "cat" starts with 1, hence we have to do +1
cat /sys/class/net/enp1s0/device/features | cut -c 4

Maybe I can link this article from the comment?

@milan-zededa
Copy link
Contributor Author

milan-zededa commented May 24, 2024

@eriknordmark I will be submitting detailed documentation on the MTU topic for the EVE repo and will describe how to check VIRTIO_NET_F_MTU and other things.
I think that I would prefer to avoid making the comment in the protofile any longer with some details and adding links that may go broke. Users do not really read comments in this repo anyway but look into the EVE documentation. WDYT?

@eriknordmark
Copy link
Contributor

Ok

@eriknordmark eriknordmark merged commit 77df971 into lf-edge:main May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants