Introduce new ZInfoNTPSource message in proto/info/ntpsource.proto
#59
Conversation
rouming
force-pushed
the
ntpsource-info-proto
branch
3 times, most recently
from
95e3a81 to
c785ecb
Compare
|
There is one yetus complain which I can't fix, because 0 state means "SYNC" and not UNSPECIFIED. |
rouming
force-pushed
the
ntpsource-info-proto
branch
3 times, most recently
from
965f12b to
f7b69fb
Compare
eriknordmark
changed the title
proto/info/ntpsource.protoproto/info/ntpsource.proto
Is NTPSourceState and NTPSourceMode from some external/standard document? If so it would be good to put a reference to such a document. |
rouming
force-pushed
the
ntpsource-info-proto
branch
from
f7b69fb to
55bd848
Compare
This will be published from EVE. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
This is autogenerated output, nothing to look at. Signed-off-by: Roman Penyaev <r.peniaev@gmail.com>
rouming
force-pushed
the
ntpsource-info-proto
branch
from
55bd848 to
ed39d66
Compare
mode and states are from the chrony itself. I added explanation and link to the sources. I fixed the yetus for _UNSPECIFIED part by keeping state and mode +1, but there are more not related to that. I do not want to spoil each line with some yetus-disabling comment. This makes code looks ugly and the overall impression is that not a tool for development, but development for the tool making it happy. As usual 90% useless. |
|
@eriknordmark could you please take a look and approve/merge if no objections. Want this changes to be taken by the other teams. Thanks. |
| message NTPSource { | ||
| bool authenticated = 1; | ||
| bool reachable = 2; // (reachability == 0xff), i.e. 8 attempts | ||
| uint32 reachability = 3; | ||
| NTPSourceState state = 4; | ||
| NTPSourceMode mode = 5; | ||
| string hostname = 6; | ||
| string src_addr = 7; | ||
| uint32 src_port = 8; | ||
| string dst_addr = 9; | ||
| uint32 dst_port = 10; | ||
| uint32 leap = 11; | ||
| uint32 stratum = 12; | ||
| uint32 precision = 13; | ||
| string ref_id = 14; | ||
| google.protobuf.Timestamp ref_time = 15; | ||
| sint32 poll = 16; | ||
| uint32 flags = 17; // bitmap from NTPSourceBitmap | ||
| double offset = 18; | ||
| double delay = 19; | ||
| double dispersion = 20; | ||
| double jitter = 21; | ||
| double root_delay = 22; | ||
| double root_disp = 23; | ||
| } |
There was a problem hiding this comment.
What will be the unique identifier?
ZInfoNTPSourcemessage contains a list of peers describing to which NTP daemon (e.g. chronyd) is synchronized on EVE side. This message will be sent periodically from EVE to the/infocontroller endpoint.CC: @zed-rishabh
CC: @eriknordmark