-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge-Node-Cluster: node, pod, volume, replica, upgrade health. #63
Edge-Node-Cluster: node, pod, volume, replica, upgrade health. #63
Conversation
Noticed a bad option in proto/info/edge_node_cluster.proto, fixing that in the next push. |
d7d57b6
to
c33f9d5
Compare
Yetus has some opinions on the naiming of enum values... |
@milan-zededa I don't see a 'make yetus' rule like the eve repo has, is there another convenience method to kick it off locally with the rules for this repo? |
ecf8888
to
c724904
Compare
Addressed the type concerns for relative -> absolute times now using google.protobuf.Timestamp. I think I'll push another change to rename the 'age' fields to 'creation_timestamp' to match field name in Kubernetes json output. |
c724904
to
db2a120
Compare
Latest commit renames 'age' fields to absolute style 'creation_timestamp' |
e487a11
to
28229bb
Compare
Latest commits had to pull ErrorInfo out to a separate file to resolve dependency issues created when adding KubeClusterInfo to InfoContent. |
Looks like there are still build issues |
28229bb
to
19d7f37
Compare
Addressed some yetus issues I missed, and separate commit for the generated go, python, svg files. |
19d7f37
to
1423e72
Compare
Reorganized and moved back ErrorInfo due to the yetus issues. I have a yetus target in my local copy of the makefile which I've been experimenting with using to try to catch these issues before a PR but it seems its not catching enough yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The publishing process of the top level message KubeClusterUpgradeStatus can be simplified if it is allowed to be a top level message type to be published. Only one node will be upgrading/updating at any time so no leader election should be needed to publish KubeClusterUpgradeStatus if the currently updating node is the only node which publishes it. The message would only be sent while the edge-node reports that it is in upgrade-test. @naiming-zededa What do you think? |
@andrewd-zededa makes sense, since the nodes are upgrade one at a time and it needs to have controller connection at the time, so update by it's own is fine. |
1423e72
to
101863d
Compare
Latest change elevates KubeClusterUpgradeStatus into the InfoContent field of ZInfoMsg. |
101863d
to
cf764bb
Compare
I'll fix a mismatch I see between 'upgrade' / 'update' conventions, I'll fix those. |
@andrewd-zededa looks like you got a conflict with Pramodh's PR. |
Yeah I'll fix the conflict, looks like I just need to regenerate the built files |
cf764bb
to
7302ca2
Compare
Updated comments on KubePodStatus, rename upgrade->update to match existing baseos update. Rebase on main and rebuilt generated files to resolve conflict. |
Looks like the two info messages KubeClusterInfo and KubeClusterUpdateStatus should probably be renamed to ZInfoKubeClusterInfo and ZInfoKubeClusterUpdateStatus but these types are getting a bit long so I'm open to suggestions to shorten them. |
7302ca2
to
78df138
Compare
Another commit pending to append to the ZInfoTypes enum. |
Node Info: role, age, ip Pod Info: status, restarts, ip Volume and Replica Info: rebuild progress, health Upgrade Status: cluster wide and node components Signed-off-by: Andrew Durbin <andrewd@zededa.com>
Signed-off-by: Andrew Durbin <andrewd@zededa.com>
78df138
to
56aa638
Compare
Need to bump eve-api after PRs lf-edge/eve-api#65 lf-edge/eve-api#63 Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
Need to bump eve-api after following PRs lf-edge/eve-api#63 lf-edge/eve-api#65 Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
Need to bump eve-api after following PRs lf-edge/eve-api#63 lf-edge/eve-api#65 Signed-off-by: Pramodh Pallapothu <pramodh@zededa.com>
Edge Node Clusters: nodes, volumes, replicas, upgrades
Node Info: role, age, ip
Pod Info: status, restarts, ip
Volume and Replica Info: rebuild progress, health
Upgrade Status: cluster wide and node components