Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use switch NI ports as VLAN access ports #64

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

milan-zededa
Copy link
Contributor

The main use-case of switch NI with multiple ports is not actually to
bridge multiple L2 switches for redundancy and run STP (*) to avoid loops,
but to allow connecting external end devices (e.g. sensors) directly
into the same L2 segment as the applications running on the edge node.
With VLAN-enabled Switch NI, the user should be able to use a physical
network port attached to Switch NI as a VLAN access port (by default
all switch NI ports are configured as trunks).

(*) Regardless of the use-case, we will always run STP on a multi-port
switch NI to avoid accidental bridge loops.

The main use-case of switch NI with multiple ports is not actually to
bridge multiple L2 switches for redundancy and run STP to avoid loops,
but to allow connecting external end devices (e.g. sensors) directly
into the same L2 segment as the applications running on the edge node.
With VLAN-enabled Switch NI, the user should be able to use a physical
network port attached to Switch NI as a VLAN access port (by default
all switch NI ports are configured as trunks).

Signed-off-by: Milan Lenco <milan@zededa.com>
Signed-off-by: Milan Lenco <milan@zededa.com>
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit f858514 into lf-edge:main Aug 16, 2024
4 checks passed
milan-zededa added a commit to milan-zededa/adam that referenced this pull request Aug 16, 2024
This will allow to use adam to test Switch network instance
with VLAN access ports, see: lf-edge/eve-api#64

Signed-off-by: Milan Lenco <milan@zededa.com>
uncleDecart pushed a commit to uncleDecart/adam that referenced this pull request Nov 26, 2024
This will allow to use adam to test Switch network instance
with VLAN access ports, see: lf-edge/eve-api#64

Signed-off-by: Milan Lenco <milan@zededa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants