Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge-Node-Cluster VMI additions #69

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

andrewd-zededa
Copy link
Contributor

Track VirtualMachineInstance for eve VMs.

@andrewd-zededa andrewd-zededa force-pushed the enc-updates-20241008 branch 3 times, most recently from 6bd5f33 to d19a7dc Compare October 9, 2024 22:47
@andrewd-zededa andrewd-zededa marked this pull request as ready for review October 11, 2024 14:31
@andrewd-zededa
Copy link
Contributor Author

@naiming-zededa @xyuria-zededa Please review as time allows.

Copy link

@xyuria-zededa xyuria-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please, wait until someone from the eve team approves

Copy link
Contributor

@naiming-zededa naiming-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a comment question/comment.

Track VirtualMachineInstance for eve VMs.

Signed-off-by: Andrew Durbin <andrewd@zededa.com>
Signed-off-by: Andrew Durbin <andrewd@zededa.com>
@andrewd-zededa
Copy link
Contributor Author

LGTM apart from a comment question/comment.

Addressed it in the latest push.

@eriknordmark eriknordmark merged commit 53b1a61 into lf-edge:main Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants