Api capability ntp fqdn #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-zededa
force-pushed
the
api_capability_ntp_fqdn
branch
2 times, most recently
from
fb0244f to
d017158
Compare
milan-zededa
approved these changes
Dec 2, 2024
eriknordmark
reviewed
Dec 3, 2024
proto/info/info.proto
Outdated
| @@ -678,6 +678,7 @@ enum APICapability { | |||
| API_CAPABILITY_MTU = 8; // Allows to set MTU for network adapters and network instances | |||
| API_CAPABILITY_ADAPTER_USER_LABELS = 9; // Supports user-defined shared network adapter labels | |||
| API_CAPABILITY_ENFORCED_NET_INTERFACE_ORDER = 10; // EVE is able to enforce the user-defined order of application network interfaces | |||
| API_CAPABILITY_NTP_FQDN = 11; // Allow to set NTP server via FQDN instead of only IP | |||
There was a problem hiding this comment.
Does this capability also include using multiple NTP servers? If so please add that to the comment.
There was a problem hiding this comment.
Yes, makes sense to include it. I changed the comment.
Add a capability to notify the controller that the NTP server cannot only by an IP address but also a domain name Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
api_capability_ntp_fqdn
branch
from
d017158 to
06def82
Compare
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 13, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 16, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 17, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 17, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 17, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 17, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 17, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
added a commit
to christoph-zededa/eve
that referenced
this pull request
Dec 17, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
eriknordmark
pushed a commit
to lf-edge/eve
that referenced
this pull request
Dec 18, 2024
Need to bump eve-api after following PR lf-edge/eve-api#77 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.