dockerfile-add-scanner: update dependencies #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-zededa
requested review from
eriknordmark and
deitch
as code owners
christoph-zededa
force-pushed
the
update_deps
branch
from
1f1aeea
to
0853020
Compare
deitch
approved these changes
Sep 2, 2024
|
@christoph-zededa it looks good, and should solve the issue, but there are conflicts. Can you resolve? |
Perhaps it then supports `COPY --exclude` in Dockerfiles? Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
update_deps
branch
from
0853020
to
8bd49ae
Compare
|
Something about the build is off? |
this is just unnecessary and insecure actually you want to use the newest version of ca-certificates as it might have excluded CAs that lost their private keys Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
update_deps
branch
from
68cdbb8
to
00a1981
Compare
It looks like this certain version of ca-certificates is not available anymore ... |
|
Yeah, it is typical of how alpine works. Oh well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perhaps it then supports
COPY --excludein Dockerfiles?