Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatchEnvelopes: move PatchEnvelopeAppUsage from App to Metrics #3664

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

uncleDecart
Copy link
Member

For API changes see lf-edge/eve-api#39

Needs to be merged after API changes

Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs to be rebased on master and pull in new API version.

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@uncleDecart uncleDecart force-pushed the move-pe-app-usage-to-metrics branch from 6dcf486 to 34883fb Compare December 15, 2023 10:24
For API changes see lf-edge/eve-api#39

Signed-off-by: Pavel Abramov <uncle.decart@gmail.com>
@uncleDecart uncleDecart force-pushed the move-pe-app-usage-to-metrics branch from 34883fb to fc7f4be Compare December 15, 2023 10:26
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (b3d1d28) 19.61% compared to head (fc7f4be) 19.60%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/pillar/cmd/volumemgr/initialvolumestatus.go 0.00% 5 Missing ⚠️
pkg/pillar/cmd/volumemgr/updatestatus.go 0.00% 5 Missing ⚠️
pkg/pillar/containerd/containerd.go 0.00% 5 Missing ⚠️
pkg/pillar/cmd/volumemgr/blob.go 0.00% 4 Missing ⚠️
pkg/pillar/cmd/volumemgr/handlevolume.go 0.00% 4 Missing ⚠️
pkg/pillar/cmd/zedagent/handlepatchenvelopes.go 0.00% 3 Missing ⚠️
pkg/pillar/cmd/zedagent/handlemetrics.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3664      +/-   ##
==========================================
- Coverage   19.61%   19.60%   -0.01%     
==========================================
  Files         232      232              
  Lines       50746    50770      +24     
==========================================
  Hits         9954     9954              
- Misses      40069    40092      +23     
- Partials      723      724       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milan-zededa milan-zededa merged commit 68b0c39 into lf-edge:master Dec 15, 2023
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants