Update eve api usb+can #3786
Merged
Update eve api usb+can #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christoph-zededa
requested review from
milan-zededa,
deitch and
eriknordmark
as code owners
|
It seems that you forgot to update the vendor folders with these changes. |
christoph-zededa
force-pushed
the
update_eve_api_usb+can
branch
4 times, most recently
from
e340dca to
558db2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3786 +/- ##
==========================================
- Coverage 19.71% 19.69% -0.02%
==========================================
Files 235 235
Lines 51757 51757
==========================================
- Hits 10204 10196 -8
- Misses 40815 40821 +6
- Partials 738 740 +2 ☔ View full report in Codecov by Sentry. |
christoph-zededa
force-pushed
the
update_eve_api_usb+can
branch
5 times, most recently
from
ef7cf85 to
063dbb1
Compare
rene
reviewed
Mar 1, 2024
Makefile
Outdated
| @@ -834,6 +834,11 @@ cache-export-docker-load-all: $(LINUXKIT) $(addsuffix -cache-export-docker-load, | |||
| proto-vendor: | |||
| @$(DOCKER_GO) "cd pkg/pillar ; go mod vendor" $(CURDIR) proto | |||
|
|
|||
| bump-eve-api: | |||
| find . -type f -name "go.mod" -exec grep -q 'github.com/lf-edge/eve-api/go' {} \; -execdir go get -u github.com/lf-edge/eve-api/go \; | |||
| find . -type f -name "go.mod" -exec grep -q 'github.com/lf-edge/eve-api/go' {} \; -execdir go mod tidy \; | |||
There was a problem hiding this comment.
You don't need to execute 3x the find command and look 3x for all files, you can just pass multiple -execdir arguments, like this:
find . -type f -name "go.mod" -exec grep -q 'github.com/lf-edge/eve-api/go' {} \; -execdir go get -u github.com/lf-edge/eve-api/go \; -execdir go mod tidy \; -execdir go mod vendor \;
063dbb1 to
5e871a4
Compare
rene
reviewed
Mar 4, 2024
| @@ -834,6 +834,9 @@ cache-export-docker-load-all: $(LINUXKIT) $(addsuffix -cache-export-docker-load, | |||
| proto-vendor: | |||
| @$(DOCKER_GO) "cd pkg/pillar ; go mod vendor" $(CURDIR) proto | |||
|
|
|||
| bump-eve-api: | |||
There was a problem hiding this comment.
@christoph-zededa , I forgot to mention that would be good to have this target explained in the make help target....
There was a problem hiding this comment.
done; please have a look at the help text
christoph-zededa
force-pushed
the
update_eve_api_usb+can
branch
from
5e871a4 to
bcfc94f
Compare
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Just autogenerated stuff after updating the eve-api and calling: make bump-eve-api Nothing to look at. Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
Signed-off-by: Christoph Ostarek <christoph@zededa.com>
christoph-zededa
force-pushed
the
update_eve_api_usb+can
branch
from
bcfc94f to
9d6baf9
Compare
rene
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to include lf-edge/eve-api#45