-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] EVE Custom EFI App to change UEFI setings #4318
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
ccb3f78
to
0155b1b
Compare
Signed-off-by: Shahriyar Jalayeri <shahriyar@zededa.com>
@shjala I do not really understand how SMBIOS custom string may affect EFI variable. Could you point me to a spec? |
} | ||
|
||
CHAR8 * | ||
GetSmbiosString( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rucoder (1/2) here I get the OEM string aka type=11,value=BlahBlah
, aka BlahBlah
in the smbios string table.
CHAR16 *ConfigValue; | ||
*TryBootOptios = FALSE; | ||
|
||
Status = GetSmbiosConfigString(EVE_TRY_ALL_BOOT, &ConfigValue); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rucoder (2/2) here I convert the smbios OEM string to the a predefined config value and then apply it based on what it is.
It won't, I read the SMBIOS custom string in my EFI application, if it is one of the pre-defined config values I parse it and then apply it. |
Reminder to add this too lf-edge/eve-api#71 |
{0x3583ff6, 0xcb36, 0x4940, {0x94, 0x7e, 0xb9, 0xb3, 0x9f, 0x4a, 0xfa, 0xf7}}; | ||
|
||
// | ||
// Randmyly generated GUID, rolled a dice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: "Randmyly" -> Randomly
@shjala , I think the approach of having an EFI app is fine, I have only one concern: in case user enters in the BIOS setup and change the resolution manually to something different from the cloud config, it won't work, so we need to have a disclaimer about that in the docs.... Maybe as a long term solution, I would consider change OVMF to fetch the config directly from our API... what do you think? Too much efforts? Worth of it? |
Also, please, keep in mind that eventually we will need to have this support for arm64 as well.... |
The idea is to not have pre-cooked OVMF_VARS files for different UEFI settings, but to have EFI application to run and manipulate the settings to our liking before booting the guest VMs.
The EVE part is janky and hacky, I will fix that in time, right now I'm more interested to know if this is viable option or not, so @rene @eriknordmark @OhmSpectator @rucoder comments are welcomed.
This is how it works :
Efi app is simple and uses gnu-efi.