Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update regex in Makefile to correctly handle rc and lts tags #4393

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

yash-zededa
Copy link
Collaborator

@yash-zededa yash-zededa commented Oct 22, 2024

We ran into an issue with the 13.4.0-rc2 actions where the Docker images were pushed to Docker Hub with the wrong names. This misnaming occurred during the image push process, leading to a failure in the associated assets. Because the images had incorrect names, the assets couldn't be properly linked or utilized, causing the overall action to fail.

The regex now supports both rc and lts, in addition to the major.minor.patch version format.

For branch example 13.4-stable

/Users/yash/lf-edge/eve/build-tools/bin/linuxkit -v pkg push   --release 13.4-stable --platforms linux/arm64 --build-yml    build.yml pkg/debug
if [ -n "1" ]; then \
		/Users/yash/lf-edge/eve/build-tools/bin/linuxkit pkg builder prune; \
		docker image prune -f; \
	fi

For tag example 13.4.0-rc3

: "eve-guacd: Begin: LINUXKIT_PKG_TARGET=push"
/Users/yash/lf-edge/eve/build-tools/bin/linuxkit -v pkg push   --release 13.4.0-rc3 --platforms linux/arm64 --build-yml    build.yml pkg/guacd
if [ -n "1" ]; then \
		/Users/yash/lf-edge/eve/build-tools/bin/linuxkit pkg builder prune; \
		docker image prune -f; \
	fi
: "eve-guacd: Succeeded (intermediate for pkg/%)"
: pkg/guacd: Succeeded

For master branch example

: "eve-guacd: Begin: LINUXKIT_PKG_TARGET=push"
/Users/yash/lf-edge/eve/build-tools/bin/linuxkit -v pkg push   --release snapshot --platforms linux/arm64 --build-yml    build.yml pkg/guacd
if [ -n "1" ]; then \
		/Users/yash/lf-edge/eve/build-tools/bin/linuxkit pkg builder prune; \
		docker image prune -f; \
	fi
: "eve-guacd: Succeeded (intermediate for pkg/%)"

The regex now supports both rc and lts, in addition to the
major.minor.patch version format.

Signed-off-by: yash-zededa <yash@zededa.com>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.93%. Comparing base (dd27fe1) to head (c6962e4).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4393   +/-   ##
=======================================
  Coverage   20.93%   20.93%           
=======================================
  Files          13       13           
  Lines        2895     2895           
=======================================
  Hits          606      606           
  Misses       2163     2163           
  Partials      126      126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yash-zededa yash-zededa marked this pull request as ready for review October 22, 2024 16:01
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but did we remove the lts tag recently? How else did 12.0 lts releases work?

@yash-zededa
Copy link
Collaborator Author

yash-zededa commented Oct 22, 2024

LGTM but did we remove the lts tag recently? How else did 12.0 lts releases work?

Because the fixes weren't part of 12.0-stable branch. Once the WF is working as expected, I will raise PR's to backport these fixes to the stable branches.

@yash-zededa yash-zededa added the stable Should be backported to stable release(s) label Oct 22, 2024
@rene
Copy link
Contributor

rene commented Oct 23, 2024

@yash-zededa , so this PR is not [WIP] anymore, right? Please, update the title to draw attention of reviewers....

@yash-zededa
Copy link
Collaborator Author

@yash-zededa , so this PR is not [WIP] anymore, right? Please, update the title to draw attention of reviewers....

Ah, Missed removing it. thanks @rene

@yash-zededa yash-zededa changed the title [WIP] fix: update regex in Makefile to correctly handle rc and lts tags fix: update regex in Makefile to correctly handle rc and lts tags Oct 23, 2024
@yash-zededa yash-zededa merged commit bdaa4e5 into lf-edge:master Oct 23, 2024
53 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable Should be backported to stable release(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants