-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update regex in Makefile to correctly handle rc and lts tags #4393
fix: update regex in Makefile to correctly handle rc and lts tags #4393
Conversation
The regex now supports both rc and lts, in addition to the major.minor.patch version format. Signed-off-by: yash-zededa <yash@zededa.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4393 +/- ##
=======================================
Coverage 20.93% 20.93%
=======================================
Files 13 13
Lines 2895 2895
=======================================
Hits 606 606
Misses 2163 2163
Partials 126 126 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but did we remove the lts tag recently? How else did 12.0 lts releases work?
Because the fixes weren't part of 12.0-stable branch. Once the WF is working as expected, I will raise PR's to backport these fixes to the stable branches. |
@yash-zededa , so this PR is not [WIP] anymore, right? Please, update the title to draw attention of reviewers.... |
Ah, Missed removing it. thanks @rene |
We ran into an issue with the 13.4.0-rc2 actions where the Docker images were pushed to Docker Hub with the wrong names. This misnaming occurred during the image push process, leading to a failure in the associated assets. Because the images had incorrect names, the assets couldn't be properly linked or utilized, causing the overall action to fail.
The regex now supports both rc and lts, in addition to the major.minor.patch version format.
For branch example
13.4-stable
For tag example
13.4.0-rc3
For master branch example