[13.4-stable] Simplify assets.yml by using wildcards and loops #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of assets to convert to `${{ env.ARCH }}` followed by the name, and then the list of uploads, was a fixed list. This made it break when anything changed.
This PR changes it so that it just converts all assets in `assets/` to prepend `${{ env.ARCH }}`, and uses the glob for uploading, `assets/${{ env.ARCH }}.*`
Signed-off-by: Avi Deitcher <avi@deitcher.net>
(cherry picked from commit 89e5e86)
rene
approved these changes
Oct 23, 2024
rene
approved these changes
Oct 23, 2024
deitch
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: 4397
The list of assets to convert to
${{ env.ARCH }}followed by the name, and then the list of uploads, was a fixed list. This made it break when anything changed. This PR changes it so that it just converts all assets inassets/to prepend${{ env.ARCH }}, and uses the glob for uploading,assets/${{ env.ARCH }}.*No changes made.
Signed-off-by: Avi Deitcher avi@deitcher.net
(cherry picked from commit 89e5e86)