Initial raspberrypi5 support #4441
Conversation
- enable booting from sd card - u-boot has no pci support for rpi5 yet, so the usb/ethernet ports are not enabled. - there is no hdmi output yet, only uart. Signed-off-by: Dimitrios Poulios <dpoulios85@gmail.com>
- enable raspberrypi5 console in grub config - use the devicetree provided by the firmware (and not the one provided by the kernel) to ensure the ethernet mac address is set correctly Signed-off-by: Dimitrios Poulios <dpoulios85@gmail.com>
| @@ -8,7 +8,9 @@ SHELL ["/bin/bash", "-eo", "pipefail", "-c"] | |||
| ENV VERSION v2024.10-rc2 | |||
| ENV SOURCE_URL https://github.com/u-boot/u-boot/archive/${VERSION}.tar.gz | |||
| ENV RASPBERRY_FIRMWARE_BLOBS_VERSION 1.20211007 | |||
| ENV RASPBERRY_FIRMWARE_BLOBS_VERSION2 1.20240306 | |||
There was a problem hiding this comment.
Should we use some more descriptive names, please?
There was a problem hiding this comment.
Probably, it would be better to get all the files from the newer version, but then I guess we should test on all raspberry devices to ensure that everything is ok.
| @@ -259,6 +259,9 @@ function set_arm64_baremetal { | |||
| smbios -t 1 -s 5 --set smb_product | |||
| if [ "$smb_product" = "rpi" ]; then | |||
| set_to_existing_file devicetree /boot/dtb/broadcom/bcm2711-rpi-4-b.dtb | |||
| elif [ "$smb_product" = "Raspberry Pi 5 Model B Rev 1.0" ]; then | |||
| #set_to_existing_file devicetree /boot/dtb/broadcom/bcm2712-rpi-5-b.dtb | |||
There was a problem hiding this comment.
Don't we need the DTB file in this case?
There was a problem hiding this comment.
Initially, I used this, but this caused the mac address to be random on each boot. Only, when using the device tree provided by the firmware (which is pretty much the same as the one in the rootfs), we get the correct mac address.
There was a problem hiding this comment.
But I don't understand how we set the DTB in this case.
And if we don't need it, we should remove the commented line...
Also, hoping @rene is taking a look here.
There was a problem hiding this comment.
If we set the device tree here, the kernel will use this one. Otherwise, it will use the one provided by the firmware/boot process (which is already loaded in the correct address). I left this as a comment, in case we find a different solution for the mac address in the future and prefer to use the kernel device tree.
There was a problem hiding this comment.
@OhmSpectator, the first dtb provided in the EFI partition (that comes from u-boot), will be dynamic updated by the firmware with relevant information, like the MAC address of the embedded NIC, so we are good to use this one instead of the provided by kernel as long as we don't put specific stuff in the kernel's dtb, which is not our case for RPi5. @dpoulios, please remove the commented line.
I think we can also do the same with RPi 4b, IIRC we just add the node for the TPM, which can be converted into an overlay... but it's okay to let this to a future PR....
| @@ -8,7 +8,9 @@ SHELL ["/bin/bash", "-eo", "pipefail", "-c"] | |||
| ENV VERSION v2024.10-rc2 | |||
| ENV SOURCE_URL https://github.com/u-boot/u-boot/archive/${VERSION}.tar.gz | |||
| ENV RASPBERRY_FIRMWARE_BLOBS_VERSION 1.20211007 | |||
| ENV RASPBERRY_FIRMWARE_BLOBS_VERSION2 1.20240306 | |||
There was a problem hiding this comment.
@dpoulios I think we can use the newest firmware for RPi model 4 as well, right? So you can just update the version on RASPBERRY_FIRMWARE_BLOBS_VERSION...
There was a problem hiding this comment.
Ok, I will do it this way and test on rpi4 & rpi5
Initial support for rpi5: