Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactor uc #1

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Add reactor uc #1

merged 10 commits into from
Dec 19, 2024

Conversation

LasseRosenow
Copy link
Collaborator

Initial draft (scripts still don't work)

make all in root should work after lfcg was run

@LasseRosenow LasseRosenow marked this pull request as draft December 11, 2024 17:52
@LasseRosenow LasseRosenow changed the base branch from main to reactor-uc December 11, 2024 17:52
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me!

@LasseRosenow
Copy link
Collaborator Author

I have removed the scripts for now and greatly simplified the Makefile, by moving things over to riot.mk in reactor-uc see: lf-lang/reactor-uc#166

I noticed a chicken-egg issue though.
Right now the LFC copies reactor-uc into the src-gen folder.
But without reactor-uc already available somewhere else we cannot use the LFC in the first place, as it is part of reactor-uc.

That is why for now I depend on the REACTOR_UC_PATH variable to be set to build this example.
Inside riot.mk we can then get the LFC path based on the REACTOR_UC_PATH variable.

What about we include reactor-uc just as a top-level submodule? maybe together with RIOT in a deps folder, or just on root.
This way this all would work out of the box and REACTOR_UC_PATH would be very clear as well.

@erlingrj
Copy link
Collaborator

@LasseRosenow, will you tag me for a review again after making modifications as discussed in today's meeting?

@LasseRosenow LasseRosenow marked this pull request as ready for review December 13, 2024 12:41
@LasseRosenow
Copy link
Collaborator Author

@erlingrj Ready for review again

@erlingrj
Copy link
Collaborator

This looks great. I have given you write access to the repo so you can push PRs directly to this instead of a fork

@erlingrj erlingrj merged commit 793722e into lf-lang:reactor-uc Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants