Additional modifications from wit-lsp
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
include-queries-in-rust
branch
from
3817484
to
829b4fc
Compare
Michael-F-Bryan
changed the title
wit-lsp
Michael-F-Bryan
force-pushed
the
include-queries-in-rust
branch
from
3849dca
to
3d0f10f
Compare
liamwh
force-pushed
the
main
branch
10 times, most recently
from
62fc4a7
to
57e31a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #8 to add a bunch of extra changes that are required by
wit-lsp.grammar.jsby extracting extra nodes and adding field names so it is possible for downstream users to more easily extract structured information from the ASTI moved this to its own PR because a lot of these changes are very specific to my use case and I don't know if I'll be breaking other users by rearranging the AST's nodes. All highlighting and parsing tests still pass, though.