Skip to content

Commit

Permalink
bpftool: Fix undefined behavior in qsort(NULL, 0, ...)
Browse files Browse the repository at this point in the history
When netfilter has no entry to display, qsort is called with
qsort(NULL, 0, ...). This results in undefined behavior, as UBSan
reports:

net.c:827:2: runtime error: null pointer passed as argument 1, which is declared to never be null

Although the C standard does not explicitly state whether calling qsort
with a NULL pointer when the size is 0 constitutes undefined behavior,
Section 7.1.4 of the C standard (Use of library functions) mentions:

"Each of the following statements applies unless explicitly stated
otherwise in the detailed descriptions that follow: If an argument to a
function has an invalid value (such as a value outside the domain of
the function, or a pointer outside the address space of the program, or
a null pointer, or a pointer to non-modifiable storage when the
corresponding parameter is not const-qualified) or a type (after
promotion) not expected by a function with variable number of
arguments, the behavior is undefined."

To avoid this, add an early return when nf_link_info is NULL to prevent
calling qsort with a NULL pointer.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Reviewed-by: Quentin Monnet <qmo@kernel.org>
Link: https://lore.kernel.org/bpf/20240910150207.3179306-1-visitorckw@gmail.com
  • Loading branch information
visitorckw authored and qmonnet committed Oct 10, 2024
1 parent 3f68270 commit 37e304d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/net.c
Original file line number Diff line number Diff line change
Expand Up @@ -880,6 +880,9 @@ static void show_link_netfilter(void)
nf_link_count++;
}

if (!nf_link_info)
return;

qsort(nf_link_info, nf_link_count, sizeof(*nf_link_info), netfilter_link_compar);

for (id = 0; id < nf_link_count; id++) {
Expand Down

0 comments on commit 37e304d

Please sign in to comment.